Could we make Materials `InheritedTheme` Public?

mickrich384 · November 7, 2024, 1:41pm

I’m assuming there are some Flutter maintainers/geniuses who can give me insight before I open a PR?

Material’s theme data can only be accessed using Theme.of(context) which will subscribe to the widget to the theme.

However there is no other way if I just want to read the theme without subscribing to it. (e.g. read the theme in a onTap callback).

To read an inherited widget without subscriving, we use the context.getInheritedWidgetOfExactType<T>() method. However the widget which holds the material data is private.

github.com

flutter/flutter/blob/673d6046b7ce285383ae2d41e0637a77c0a6e1bf/packages/flutter/lib/src/material/theme.dart#L169-L185


      
          
          class _InheritedTheme extends InheritedTheme {
            const _InheritedTheme({
              required this.theme,
              required super.child,
            });
          
            final Theme theme;
          
            @override
            Widget wrap(BuildContext context, Widget child) {
              return Theme(data: theme.data, child: child);
            }
          
            @override
            bool updateShouldNotify(_InheritedTheme old) => theme.data != old.theme.data;
          }

So my question is, why is it private? Can we make it public (e.g InheritedMaterialTheme)